-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NUI] Add VisibilityChanged event to Layer #5398
[NUI] Add VisibilityChanged event to Layer #5398
Conversation
Internal API ChangedAdded: 5, Removed: 0, Changed: 0Added+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.EventHandler`1<Tizen.NUI.Layer/VisibilityChangedEventArgs> Tizen.NUI.Layer::VisibilityChanged
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.Layer/VisibilityChangedEventArgs
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Boolean Tizen.NUI.Layer/VisibilityChangedEventArgs::Visibility()
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.Layer Tizen.NUI.Layer/VisibilityChangedEventArgs::Layer()
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.Layer/VisibilityChangedEventArgs::.ctor()
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should'nt we have to Disconnect at Dispose()
??
[EditorBrowsable(EditorBrowsableState.Never)] | ||
public class VisibilityChangedEventArgs : EventArgs | ||
{ | ||
private Layer _layer; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NUI 네이밍 룰과 맞지 않는 사용인거 같아요 '_layer'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your comment!
NUI naming rule is applied.
dc74245
to
bde93f0
Compare
Internal API ChangedAdded: 5, Removed: 0, Changed: 0Added+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.EventHandler`1<Tizen.NUI.Layer/VisibilityChangedEventArgs> Tizen.NUI.Layer::VisibilityChanged
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.Layer/VisibilityChangedEventArgs
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Boolean Tizen.NUI.Layer/VisibilityChangedEventArgs::Visibility()
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.Layer Tizen.NUI.Layer/VisibilityChangedEventArgs::Layer()
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.Layer/VisibilityChangedEventArgs::.ctor()
|
To notice the visibility changes of Layer, VisibilityChanged event is added to Layer.
bde93f0
to
67610fc
Compare
Thank you for your comment! |
Internal API ChangedAdded: 5, Removed: 0, Changed: 0Added+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.EventHandler`1<Tizen.NUI.Layer/VisibilityChangedEventArgs> Tizen.NUI.Layer::VisibilityChanged
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.Layer/VisibilityChangedEventArgs
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Boolean Tizen.NUI.Layer/VisibilityChangedEventArgs::Visibility()
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.Layer Tizen.NUI.Layer/VisibilityChangedEventArgs::Layer()
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.Layer/VisibilityChangedEventArgs::.ctor()
|
To notice the visibility changes of Layer, VisibilityChanged event is added to Layer.
Description of Change
API Changes